[KYUUBI #6358] Fix the incorrect construction of yarnConf #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for a pro to fix this issue.😁 |
wForget
reviewed
May 11, 2024
| @@ -56,6 +56,7 @@ trait ApplicationOperation { | |||
| * @note For implementations, please suppress exceptions and always return KillResponse | |||
| */ | |||
| def killApplicationByTag( | |||
| sessionConf: Option[KyuubiConf], | |||
There was a problem hiding this comment.
Suggested change
| sessionConf: Option[KyuubiConf], | |
| def killApplicationByTag( | |
| appMgrInfo: ApplicationManagerInfo, | |
| tag: String, | |
| proxyUser: Option[String] = None, | |
| sessionConf: Option[KyuubiConf] = None): KillResponse |
wForget
reviewed
May 11, 2024
| case e: Exception => | ||
| (false, s"Failed to terminate application with $tag, due to ${e.getMessage}") | ||
| proxyUser: Option[String] = None): KillResponse = | ||
| withNewYarnClient(proxyUser, sessionConf) { yarnClient => |
There was a problem hiding this comment.
It seems that newYarnClient is not always needed. Can we use it only when needed? Like, the hadoop_conf_dir/yarn_conf_dir engine evn exists in sessionConf.
There was a problem hiding this comment.
Thanks for your help, you're right, I'll make the changes.
wForget
reviewed
May 11, 2024
| Utils.doAs(user) { () => | ||
| var yarnClient: YarnClient = null | ||
| try { | ||
| val yarnConf = KyuubiHadoopUtils.newYarnConfiguration(sessionConf) |
There was a problem hiding this comment.
Does this use kyuubi.engineEnv.HADOOP_CONF_DIR/YARN_CONF_DIR in sessionConf to initialize yarnConf?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
#6385
Describe Your Solution 🔧
This PR is just for better explaining this issue and for testing. The fix is quite crude, and there are still many issues not addressed.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.