-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-15561 [2/N]: Background event and subscription state changes for RE2J pattern #17918
Conversation
FYI, next PR will contain the integration with the HB and integration tests. |
@@ -108,13 +112,21 @@ private enum SubscriptionType { | |||
public synchronized String toString() { | |||
return "SubscriptionState{" + | |||
"type=" + subscriptionType + | |||
", subscribedPattern=" + subscribedPattern + | |||
", subscribedPattern=" + subscribedPatternInUse() + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm intentionally avoiding differentiating the 2 patterns output thinking that it will help have a smooth transition when we end up deprecating/removing the old pattern in the future. Makes sense?
Comment regarding the mixed subscription error msg in kafka/clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java Line 74 in 33318bc
It's truly not clearly stating that we don't allow pattern and re2j pattern together (we don't), but I intentionally didn't change it wondering if it's more of a hassle given that this is expected to be a transition period until we deprecate (eventually remove) the old regex, and then the current msg will be fully accurate as it is. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r RE2J pattern (apache#17918) Reviewers: David Jacot <[email protected]>
This PR includes: