MINOR: Improve Docker examples readme #17894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds some clarity about the environment variables usage and limitations. It also removes the invalid example and adds few style fixes. Signed-off-by: Federico Valeri <[email protected]>
showuon
reviewed
Nov 25, 2024
|
@VedarthConfluent @kagarwal06, call for review. Thanks. |
VedarthConfluent
approved these changes
Nov 25, 2024
Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
docker-readme
branch
from
f5173f8
to
d562618
Compare
|
Why are we keeping this information in a README, shouldn't this be directly part of the documentation? |
+1. @fvaleri , could you help create a JIRA and if you have time, adding the content in README to the doc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds some clarity about the environment variables usage and limitations. It also removes the invalid example and adds few style fixes.
See #17705 (comment).