Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: Fix filter issue when both tree extraction and table extraction are enabled and one extraction has non default pattern #14184

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

SteveYurongSu
Copy link
Member

No description provided.

… are enabled and one extraction has non default pattern
@SteveYurongSu SteveYurongSu self-assigned this Nov 22, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 39.63%. Comparing base (d171a53) to head (8798989).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...istoricalDataRegionTsFileAndDeletionExtractor.java 5.88% 16 Missing ⚠️
...gion/realtime/PipeRealtimeDataRegionExtractor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14184      +/-   ##
============================================
+ Coverage     39.62%   39.63%   +0.01%     
  Complexity       71       71              
============================================
  Files          4230     4230              
  Lines        269606   269620      +14     
  Branches      32683    32686       +3     
============================================
+ Hits         106831   106864      +33     
+ Misses       162775   162756      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@luoluoyuyu luoluoyuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@SteveYurongSu SteveYurongSu merged commit 76066d4 into master Nov 22, 2024
34 checks passed
@SteveYurongSu SteveYurongSu deleted the fix-filter branch November 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants