Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: Fixed the bug that different types in schema snapshot transfer may cause transfer failure #13627

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,18 @@ private void executeInternalCreateAlignedTimeSeries(
encodingList.remove(index);
compressionTypeList.remove(index);

// If with merge is set, the lists are deep copied and need to be altered here.
// We still remove the element from the original list to help cascading pipe transfer
// schema.
// If this exception is thrown, the measurements, data types, etc. must be unchanged.
// Thus, the index for the copied lists are identical to that in the original lists.
if (withMerge) {
createAlignedTimeSeriesPlan.getMeasurements().remove(index);
createAlignedTimeSeriesPlan.getDataTypes().remove(index);
createAlignedTimeSeriesPlan.getEncodings().remove(index);
createAlignedTimeSeriesPlan.getCompressors().remove(index);
}

if (measurementList.isEmpty()) {
shouldRetry = false;
}
Expand Down
Loading