Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-std: optee-utee: make panic_handler optional #147

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

ivila
Copy link
Contributor

@ivila ivila commented Oct 25, 2024

Make panic_handler optional for no-std TAs by adding "no_panic_handler" feature flag. It allows no-std TAs to have a custom panic handler.
Relative issue is here: #145

This PR is a recreate one, the former PR was closed due to using the wrong branch(as metioned in #143 , the only maintenance branch should be main.

optee-utee/src/lib.rs Outdated Show resolved Hide resolved
@DemesneGH
Copy link
Contributor

LGTM. @b49020 any comments?

@b49020
Copy link
Contributor

b49020 commented Oct 25, 2024

With the patches squashed, feel free to add:

Reviewed-by: Sumit Garg <[email protected]>

@DemesneGH
Copy link
Contributor

Ready to merge, please squash the commits into one and append the tags in commit message:

Signed-off-by: [YOUR NAME] <YOUR_EMAIL>
Reviewed-by: Sumit Garg <[email protected]>
Reviewed-by: Yuan Zhuang <[email protected]>

Thanks!

Make panic_handler optional for no-std TAs by adding "no_panic_handler"
feature flag. It allows no-std TAs to have a custom panic handler.

Signed-off-by: ivila <[email protected]>
Reviewed-by: Sumit Garg <[email protected]>
Reviewed-by: Yuan Zhuang <[email protected]>
@ivila
Copy link
Contributor Author

ivila commented Oct 25, 2024

Sorry for late reply, done.

@DemesneGH DemesneGH merged commit b5143c6 into apache:main Oct 25, 2024
@DemesneGH
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants