[incubator-kie-issues#1596] Adding Business Calendar Example #2036

Abhitocode · 2024-11-05T16:31:03Z

Closes: apache/incubator-kie-issues#1596

Added an example ensuring business calendar functionality to kogito-quarkus-examples.
The example includes a simple process that uses a business calendar. The example contains a README with clear step by step instructions, and incorporates all supporting resources required. The priority would be having this example for Quarkus.

…1596

gitgabrio · 2024-11-05T16:31:56Z

Reopened from #2031

…nto incubator-kie-issues#1596

kie-ci3 · 2024-11-06T17:12:57Z

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2036 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2036/2/display/redirect

Test results:

PASSED: 123
FAILED: 1

Those are the test failures:

org.kie.kogito.calendar.CreditCardProcessIT.testCardPaymentInWorkingDay

1 expectation failed.
Response body doesn't match expectation.
Expected: "[]"
Actual: [{"id":"34985152-e934-422d-befe-0f6ab4333bfd","creditCardNumber":null,"creditCardDetails":{"cardNumber":"434354343","status":"Bill Due"}}]

kie-ci3 · 2024-11-06T18:46:10Z

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2036 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2036/3/display/redirect

Test results:

PASSED: 170
FAILED: 1

Those are the test failures:

org.kie.kogito.calendar.CreditCardProcessIT.testCardPaymentInWorkingDay

1 expectation failed.
Response body doesn't match expectation.
Expected: "[]"
Actual: [{"id":"4267f444-8674-4514-9f79-186ed782bc0f","creditCardNumber":null,"creditCardDetails":{"cardNumber":"434354343","status":"Bill Due"}}]

kie-ci3 · 2024-11-06T21:33:46Z

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2036 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2036/4/display/redirect

Test results:

PASSED: 394
FAILED: 1

Those are the test failures:

org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards

1 expectation failed.
JSON path title doesn't match.
Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard"
Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Hello - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Operational Dashboard]>

kogito-quarkus-examples/process-business-calendar-example/README.md

kogito-quarkus-examples/pom.xml

yesamer · 2024-11-12T08:11:50Z

Hi @Abhitocode, if this is Ready for review, please move its status from Draft to "Ready for review". Thanks

kie-ci3 · 2024-11-12T08:48:38Z

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2036 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2036/11/display/redirect

Test results:

PASSED: 400
FAILED: 1

Those are the test failures:

org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards

1 expectation failed.
JSON path title doesn't match.
Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard"
Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Hello - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Operational Dashboard]>

kogito-quarkus-examples/process-business-calendar-example/README.md

martinweiler

The section on running without calendar.properties file needs to be updated.

yesamer

Reporting a couple of minor points

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties

jomarko

Thank you for this PR. It seems very good feature. I have done some tests locally. I agree with others that maybe we could enhance the documentation a little bit.

...-business-calendar-example/src/main/java/org/kie/kogito/calendar/bill/CreditCardService.java

kogito-quarkus-examples/process-business-calendar-example/README.md

jomarko · 2024-11-13T10:04:14Z

kogito-quarkus-examples/process-business-calendar-example/README.md

+
+```sh
+mvn clean package
+java -jar target/quarkus-app/quarkus-run.jar


this somehow does not work on my machine:

I tried again, works for, not sure exactly what might be causing the issue in your case

enabled it in the application.properties, should work now.

jomarko · 2024-11-13T10:10:42Z

kogito-quarkus-examples/process-business-calendar-example/README.md

+Note that this requires GRAALVM_HOME to point to a valid GraalVM installation
+
+```sh
+mvn clean package -Pnative


I was not able to finish this build:

[INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 05:16 min [INFO] Finished at: 2024-11-13T11:09:29+01:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.8.6:build (default) on project process-business-calendar-example: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [ERROR] [error]: Build step io.quarkus.deployment.pkg.steps.NativeImageBuildStep#build threw an exception: io.quarkus.deployment.pkg.steps.NativeImageBuildStep$ImageGenerationFailureException: Image generation failed. Exit code: 1 [ERROR] at io.quarkus.deployment.pkg.steps.NativeImageBuildStep.imageGenerationFailed(NativeImageBuildStep.java:468) [ERROR] at io.quarkus.deployment.pkg.steps.NativeImageBuildStep.build(NativeImageBuildStep.java:258) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:568) [ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849) [ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:256) [ERROR] at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538) [ERROR] at java.base/java.lang.Thread.run(Thread.java:840) [ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:501) [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

jomarko · 2024-11-13T10:26:46Z

kogito-quarkus-examples/process-business-calendar-example/README.md

+business.hours.per.day=24                # Defines the number of hours per working day (e.g., business.hours.per.day=24 for a 24-hour workday)
+business.days.per.week =7                # Defines how many days are considered working days (e.g.,7 means all days are working days)
+business.holiday.date.format=yyyy-MM-dd  # specifies holiday date format used
+business.holidays=2024-11-07             # Add custom holidays that are non-working days, specified in the format defined by business.holiday.date.format 


how to define multiple days or periods, is that possible? asking because there are usually more holidays during the year

multiple holidays: 2024-11-13, 2024-11-14
In a range 2024-11-14:2024-11-14

Thank you for the pointing it, just remebered to add the same in the readme too.

kogito-quarkus-examples/process-business-calendar-example/README.md

jomarko · 2024-11-13T10:34:55Z

...example/src/main/resources/org/kie/calendar/bill/BPMN2-BusinessCalendarBankTransaction.bpmn2

+  <bpmn2:collaboration id="_DCDB6E8C-F47A-4DBC-B34A-046A81E24F95" name="Default Collaboration">
+    <bpmn2:participant id="_D18AFD4D-A5A8-4C66-8259-5D9CF9B946FA" name="Pool Participant" processRef="BusinessCalendarCreditBill"/>
+  </bpmn2:collaboration>
+  <bpmn2:process id="BusinessCalendarCreditBill" drools:packageName="org.kie.calendar.bill" drools:version="1.0" drools:adHoc="false" name="BusinessCalendar-CreditBill" isExecutable="true" processType="Public">


maybe we could unify the packages, in src/main/java we have org.kie.kogito.calendar.bill while in src/main/resources we have org.kie.calendar.bill

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties

kogito-quarkus-examples/process-business-calendar-example/README.md

gitgabrio

Hi @Abhitocode
Many thanks for the example. And, mostly, for the documentation ❤️
LGTM

yesamer

@Abhitocode Thank you, well done!

martinweiler

Great work @Abhitocode
Thanks for your diligence incorporating all the feedback!

jomarko

Thank you for updates @Abhitocode

…2036) * business-calendar-example * business-calendar-example * business-calendar-example * business-calendar-example * business-calendar-example * business-calendar-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example * incubator-kie-issues-1596-bc-example

Abhitocode added 8 commits October 31, 2024 06:18

business-calendar-example

f722c11

business-calendar-example

9902fcb

business-calendar-example

9885344

business-calendar-example

79afc8e

business-calendar-example

d7f848d

business-calendar-example

8776bd4

incubator-kie-issues-1596-bc-example

66cbd6d

Merge remote-tracking branch 'origin/main' into incubator-kie-issues-…

251f233

…1596

Abhitocode marked this pull request as draft November 5, 2024 16:31

gitgabrio requested review from gitgabrio and yesamer November 5, 2024 16:31

Abhitocode mentioned this pull request Nov 5, 2024

[incubator-kie-issues#1596] Adding Business Calendar Example #2031

Closed

Abhitocode added 3 commits November 6, 2024 10:49

incubator-kie-issues-1596-bc-example

7229d4e

incubator-kie-issues-1596-bc-example

a18aa1b

Merge remote-tracking branch 'Abhitocode/incubator-kie-issues#1596' i…

5db4a4b

…nto incubator-kie-issues#1596

incubator-kie-issues-1596-bc-example

0114f07

Abhitocode added 2 commits November 7, 2024 09:20

incubator-kie-issues-1596-bc-example

6b5eb73

incubator-kie-issues-1596-bc-example

ee15459

gitgabrio requested changes Nov 11, 2024

View reviewed changes

Abhitocode added 5 commits November 11, 2024 09:07

incubator-kie-issues-1596-bc-example

afe0e81

incubator-kie-issues-1596-bc-example

0d27c4e

incubator-kie-issues-1596-bc-example

5800d67

incubator-kie-issues-1596-bc-example

13f610f

incubator-kie-issues-1596-bc-example

315ecbb

Abhitocode marked this pull request as ready for review November 12, 2024 13:58

martinweiler reviewed Nov 12, 2024

View reviewed changes

kogito-quarkus-examples/process-business-calendar-example/README.md Outdated Show resolved Hide resolved

martinweiler requested changes Nov 12, 2024

View reviewed changes

yesamer reviewed Nov 13, 2024

View reviewed changes

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

jomarko reviewed Nov 13, 2024

View reviewed changes

Abhitocode added 3 commits November 13, 2024 13:08

incubator-kie-issues-1596-bc-example

68e75ba

incubator-kie-issues-1596-bc-example

0e1f42f

incubator-kie-issues-1596-bc-example

df97315

yesamer reviewed Nov 14, 2024

View reviewed changes

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

yesamer reviewed Nov 14, 2024

View reviewed changes

...to-quarkus-examples/process-business-calendar-example/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

yesamer reviewed Nov 14, 2024

View reviewed changes

kogito-quarkus-examples/process-business-calendar-example/README.md Outdated Show resolved Hide resolved

yesamer reviewed Nov 14, 2024

View reviewed changes

kogito-quarkus-examples/process-business-calendar-example/README.md Outdated Show resolved Hide resolved

yesamer reviewed Nov 14, 2024

View reviewed changes

kogito-quarkus-examples/process-business-calendar-example/README.md Outdated Show resolved Hide resolved

Abhitocode added 4 commits November 14, 2024 08:48

incubator-kie-issues-1596-bc-example

5269084

incubator-kie-issues-1596-bc-example

69e2990

incubator-kie-issues-1596-bc-example

9483dee

incubator-kie-issues-1596-bc-example

a8c402f

Abhitocode requested a review from martinweiler November 14, 2024 14:29

gitgabrio approved these changes Nov 14, 2024

View reviewed changes

yesamer approved these changes Nov 14, 2024

View reviewed changes

martinweiler approved these changes Nov 14, 2024

View reviewed changes

jomarko approved these changes Nov 14, 2024

View reviewed changes

yesamer merged commit 21fd453 into apache:main Nov 14, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator-kie-issues#1596] Adding Business Calendar Example #2036

[incubator-kie-issues#1596] Adding Business Calendar Example #2036

Abhitocode commented Nov 5, 2024 •

edited

Loading

gitgabrio commented Nov 5, 2024

kie-ci3 commented Nov 6, 2024

kie-ci3 commented Nov 6, 2024

kie-ci3 commented Nov 6, 2024

yesamer commented Nov 12, 2024

kie-ci3 commented Nov 12, 2024

martinweiler left a comment

yesamer left a comment

jomarko left a comment

jomarko Nov 13, 2024

Abhitocode Nov 14, 2024

Abhitocode Nov 14, 2024

jomarko Nov 13, 2024

jomarko Nov 13, 2024

Abhitocode Nov 14, 2024

jomarko Nov 13, 2024

gitgabrio left a comment

yesamer left a comment

martinweiler left a comment

jomarko left a comment

[incubator-kie-issues#1596] Adding Business Calendar Example #2036

[incubator-kie-issues#1596] Adding Business Calendar Example #2036

Conversation

Abhitocode commented Nov 5, 2024 • edited Loading

gitgabrio commented Nov 5, 2024

kie-ci3 commented Nov 6, 2024

kie-ci3 commented Nov 6, 2024

kie-ci3 commented Nov 6, 2024

yesamer commented Nov 12, 2024

kie-ci3 commented Nov 12, 2024

martinweiler left a comment

Choose a reason for hiding this comment

yesamer left a comment

Choose a reason for hiding this comment

jomarko left a comment

Choose a reason for hiding this comment

jomarko Nov 13, 2024

Choose a reason for hiding this comment

Abhitocode Nov 14, 2024

Choose a reason for hiding this comment

Abhitocode Nov 14, 2024

Choose a reason for hiding this comment

jomarko Nov 13, 2024

Choose a reason for hiding this comment

jomarko Nov 13, 2024

Choose a reason for hiding this comment

Abhitocode Nov 14, 2024

Choose a reason for hiding this comment

jomarko Nov 13, 2024

Choose a reason for hiding this comment

gitgabrio left a comment

Choose a reason for hiding this comment

yesamer left a comment

Choose a reason for hiding this comment

martinweiler left a comment

Choose a reason for hiding this comment

jomarko left a comment

Choose a reason for hiding this comment

Abhitocode commented Nov 5, 2024 •

edited

Loading