Updates to knative docs #1253
Closed
Updates to knative docs #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisv
requested changes
May 18, 2022
| 3. Install Knative using the [quickstart](https://knative.dev/docs/getting-started/) since a DNS will be configured for you. In case you need to restart Minikube, make sure you start it using the `knative` profile by running `minikube start -p knative`. | ||
| 4. Install the [Knative Kogito Source](https://github.com/knative-sandbox/eventing-kogito#installation). | ||
| 5. Run `eval $(minikube -p minikube docker-env --profile knative)` to build the images in your internal Minikube registry. | ||
| 6. Run `mvn clean install -Pknative` to build and push the image to Minibuke registry and generate the Knative resources for your application to run. |
| 3. Install Knative using the [quickstart](https://knative.dev/docs/getting-started/) since a DNS will be configured for you. In case you need to restart Minikube, make sure you start it using the `knative` profile by running `minikube start -p knative`. | ||
| 4. Install the [Knative Kogito Source](https://github.com/knative-sandbox/eventing-kogito#installation). | ||
| 5. Run `eval $(minikube -p minikube docker-env --profile knative)` to build the images in your internal Minikube registry. | ||
| 6. Run `mvn clean install -Pknative` to build and push the image to Minibuke registry and generate the Knative resources for your application to run. |
| 2. Enable Minikube internal image registry by running `minikube addons enable registry` | ||
| 3. Install Knative using the [quickstart](https://knative.dev/docs/getting-started/) since a DNS will be configured for you. In case you need to restart Minikube, make sure you start it using the `knative` profile by running `minikube start -p knative`. | ||
| 4. Install the [Knative Kogito Source](https://github.com/knative-sandbox/eventing-kogito#installation). | ||
| 5. Run `eval $(minikube -p minikube docker-env --profile knative)` to build the images in your internal Minikube registry. |
There was a problem hiding this comment.
This might be a little but confusing, maybe reword a little bit, like: "This configures your terminal to use the internal Minikube docker instance"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.