Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIE-DROOLS-6190] fix removal of detached tuples during incremental compilation #6192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mariofusco
Copy link
Contributor

Fixes #6190

There are a few other incremental compilation tests that are failing for a totally unrelated reason and anyway without causing any endless loop. I left them disabled and I will keep investigating and fix them with a subsequent pull request.

@kie-ci3
Copy link

kie-ci3 commented Dec 11, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6192 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6192/1/display/redirect

Test results:

  • PASSED: 41085
  • FAILED: 1

Those are the test failures:

org.drools.mvel.integrationtests.Misc2Test.testDynamicAddRule(KieBaseTestConfiguration)[1]
Expecting value to be true but was false

@kie-ci3
Copy link

kie-ci3 commented Dec 11, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6192 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6192/2/display/redirect

Test results:

  • PASSED: 41085
  • FAILED: 1

Those are the test failures:

org.drools.mvel.integrationtests.Misc2Test.testDynamicAddRule(KieBaseTestConfiguration)[1]
Expecting value to be true but was false

@tkobayas tkobayas self-requested a review December 12, 2024 02:24
@tkobayas
Copy link
Contributor

Test failure on Misc2Test.testDynamicAddRule needs to be addressed.

Other test failures in kogito-* are mostly "pull access denied for vectorized/redpanda", which is being investigated by apache/incubator-kie-issues#1682

@mariofusco
Copy link
Contributor Author

Test failure on Misc2Test.testDynamicAddRule needs to be addressed.

It's good that we had that test, it gave me a better insight of what @mdproctor was attempting to do there and where the problem actually was. This should be fixed now.

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests failing in incremental compilation
4 participants