-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat&refact:add jdbc date type support&Synchronized editorconfig #648
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for your contribution, could refer the doc to format the code: (to avoid a lot of unexpected changes)
|
Thank you for the reminder. After I checked my code style, I'm pretty sure I have already opened that configuration. Also, I noticed that:
It doesn't work on my IDEA version: "IntelliJ IDEA 2024.3.1 (Ultimate Edition)".
I changed "continuation_indent_size" to "ij_continuation_indent_size", and it worked well,maybe i should ask another issue |
…、 TIMESTAMP and YEAR
a7ebedc
to
00b5cc5
Compare
b08e9c0
to
fcb987a
Compare
fcb987a
to
843e513
Compare
Thanks for the feedback, we also had separate configuration options for @MuLeiSY2021 Ur right, we should sync the config file with the main repo https://github.com/apache/incubator-hugegraph/blob/master/.editorconfig, u could sync it in this PR if needed (And reformat your code again, thx) |
0c4bf37
to
66d4480
Compare
Purpose of the PR
add jdbc date type support include DATE、TIME、 DATETIME、 TIMESTAMP and YEAR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need