fix: yarn library license issues #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Nov 20, 2023
| @@ -1,34 +1,6 @@ | |||
| #!/usr/bin/env node | |||
| /* eslint-disable */ | |||
| //prettier-ignore | |||
| /*! | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
can you at least add a link for the LICENSE file but ideally you should list the licenses here?
There was a problem hiding this comment.
I think so, the bsd license should be listed here just like the apache license is listed in other files
LICENSE
Outdated
| @@ -234,32 +234,24 @@ SOFTWARE. | |||
|
|
|||
| -------------------------------------------------------------------------------- | |||
|
|
|||
| The following file is distributed under the BSD 2-Clause License: | |||
| The following file is distributed under the Licenses: | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pjfanning
reviewed
Nov 21, 2023
| @@ -234,14 +234,11 @@ SOFTWARE. | |||
|
|
|||
| -------------------------------------------------------------------------------- | |||
|
|
|||
| The following file is distributed under the BSD 2-Clause License: | |||
| The following file is distributed under different licenses: | |||
There was a problem hiding this comment.
it looks like they have listed them all, although perhaps not quite in the format I would have chosen.
There was a problem hiding this comment.
Hi justin, thank you very much for your question. Regarding the format you mentioned, I would like to ask you to clarify which format you are referring to.
abeizn
added
bot/auto-cherry-pick-for-release-v0.19
d4x1
approved these changes
Nov 24, 2023
abeizn
added
needs-cherrypick-v0.19
and removed
bot/auto-cherry-pick-for-release-v0.19
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
* fix: yarn library use license * fix: typo * fix: yarn software license issues
|
🤖 cherry pick finished successfully 🎉! |
github-actions
bot
added
the
bot/auto-cherry-pick-completed
abeizn
added a commit
that referenced
this pull request
Nov 24, 2023
* fix: yarn library use license * fix: typo * fix: yarn software license issues Co-authored-by: abeizn <[email protected]>
abeizn
added
needs-cherrypick-v0.20
and removed
bot/auto-cherry-pick-completed
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
* fix: yarn library use license * fix: typo * fix: yarn software license issues
|
🤖 cherry pick finished successfully 🎉! |
github-actions
bot
added
the
bot/auto-cherry-pick-completed
abeizn
added a commit
that referenced
this pull request
Nov 24, 2023
* fix: yarn library use license * fix: typo * fix: yarn software license issues Co-authored-by: abeizn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: yarn library license issues
Does this close any open issues?
Closes na
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.