-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): remove x-cray/logrus-prefixed-formatter #5690
Conversation
Before cc @ZhangNing10 |
@d4x1 Is the func/file always pointing to the logruslog logger? |
I have searched this repo, only logrus was found, all logger is inited in package logruslog. And I run the devlake backend, logger in handlers and plugins are both worked as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@d4x1 Please run |
Please don't merge this PR, I find the line number is always |
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
What does this PR do?
Fix #5666
Does this close any open issues?
Closes #5666
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.