Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] update victoriametrics and greptime store #2836

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Conversation

tomsun28
Copy link
Contributor

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation webapp script labels Nov 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2867 files.

Valid Invalid Ignored Fixed
1473 1 1393 0
Click to see the invalid file list
  • hertzbeat-warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/history/vm/PromQlQueryContent.java
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 184 lines in your changes missing coverage. Please review.

Project coverage is 32.71%. Comparing base (8cdc92a) to head (4b42da5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../store/history/greptime/GreptimeDbDataStorage.java 0.00% 82 Missing ⚠️
.../history/vm/VictoriaMetricsClusterDataStorage.java 0.00% 46 Missing ⚠️
...e/store/history/vm/VictoriaMetricsDataStorage.java 0.00% 39 Missing ⚠️
...warehouse/store/history/vm/PromQlQueryContent.java 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2836      +/-   ##
============================================
+ Coverage     32.55%   32.71%   +0.15%     
  Complexity     1904     1904              
============================================
  Files           496      497       +1     
  Lines         18316    18240      -76     
  Branches       2250     2239      -11     
============================================
+ Hits           5963     5967       +4     
+ Misses        11656    11576      -80     
  Partials        697      697              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tomsun28 and others added 5 commits November 24, 2024 21:11
Signed-off-by: tomsun28 <[email protected]>
…se/store/history/vm/PromQlQueryContent.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Logic <[email protected]>
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zqr10159
Copy link
Member

Whether you need to add the necessary alerts to the documentation because the application.yml configuration changes in the case of binary installers

@Aias00 Aias00 merged commit fc8be06 into master Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation script webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants