Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] use post request refresh token #2720

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[improve] use post request refresh token #2720

merged 2 commits into from
Sep 16, 2024

Conversation

tomsun28
Copy link
Contributor

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.98%. Comparing base (a34ccdd) to head (a95004b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rg/apache/hertzbeat/manager/pojo/dto/TokenDto.java 60.00% 2 Missing ⚠️
...ertzbeat/manager/controller/AccountController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2720   +/-   ##
=========================================
  Coverage     31.98%   31.98%           
- Complexity     1692     1694    +2     
=========================================
  Files           406      407    +1     
  Lines         16438    16443    +5     
  Branches       2134     2134           
=========================================
+ Hits           5257     5260    +3     
- Misses        10543    10546    +3     
+ Partials        638      637    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit ca27605 into master Sep 16, 2024
4 checks passed
@zqr10159 zqr10159 deleted the post-token branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants