Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support monitoring NebulaGraph metrics and add help doc #1441

Merged
merged 2 commits into from
Dec 24, 2023
Merged

support monitoring NebulaGraph metrics and add help doc #1441

merged 2 commits into from
Dec 24, 2023

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Dec 23, 2023

What's changed?

image
image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Dec 23, 2023
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 23, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍LGTM!

Comment on lines +25 to +26
# 监控类型的帮助描述信息
helpLink:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi please add the help and helplink like this:

# The description and help of this monitoring type
# 监控类型的帮助描述信息
help:
  zh-CN: Hertzbeat 将调用 HTTP API 接口,查看接口是否可用,并以 ms 为指标单位对其响应时间等指标进行监测。您可以先点击“新增 HTTP API”按钮并进行配置,或在“更多操作”中导入已有配置。
  en-US: The platform will invoke an HTTP API endpoint to verify its accessibility and monitor various metrics, including response time, measured in milliseconds (ms). <br>To set up this functionality, you could click the "Add HTTP API" button and proceed with the configuration or import an existing setup through the "More Actions" menu.
  zh-TW: Hertzbeat將調用HTTP API介面,查看介面是否可用,並以ms為名額組織對其回應時間等名額進行監測。 您可以先點擊“新增HTTP API”按鈕並進行配寘,或在“更多操作”中導入已有配寘。
helpLink:
  zh-CN: https://hertzbeat.com/zh-cn/docs/help/api
  en-US: https://hertzbeat.com/docs/help/api

@tomsun28 tomsun28 merged commit 6e34605 into apache:master Dec 24, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants