[#6139] Refactor metalake command in Gravitino CLI #6140
+336
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaofengshi and @tengqm what do you think of this? It's mostly cosmetic but does make it easier to understand. |
@justinmclean Should we split other commands？ |
12 tasks
tengqm
reviewed
Jan 8, 2025
| * Constructs a MetalakeCommandHandler instance. | ||
| * | ||
| * @param gravitinoCommandLine The Gravitino command line instance. | ||
| * @param line The command line options. |
There was a problem hiding this comment.
rename line to options or arguments ?
There was a problem hiding this comment.
The variable name line is used elsewhere e.g. FullName, GravitinoCommandLine and Main, options might be a little confusing as that is a different class.
|
@Abyss-lord You can start working on the other sub-issues for this if you want. |
|
@shaofengshi can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Gravitino command line class is a little large and could be broken up.
Why are the changes needed?
For readability and maintainability.
Fix: #6139
Does this PR introduce any user-facing change?
None.
How was this patch tested?
Tested locally.