[#6078] feat(core): Support model event to Gravitino server #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengqm
reviewed
Jan 8, 2025
| public GetModelVersionEvent( | ||
| String user, NameIdentifier identifier, ModelInfo getModelVersionInfo) { | ||
| super(user, identifier); | ||
| GetModelVersionInfo = getModelVersionInfo; |
There was a problem hiding this comment.
Suggested change
| GetModelVersionInfo = getModelVersionInfo; | |
| this.info = getModelVersionInfo; |
| * @param model the model to expose information for. | ||
| * @param modelVersion the versions of the model. | ||
| */ | ||
| public ModelInfo(Model model, ModelVersion[] modelVersion) { |
There was a problem hiding this comment.
Suggested change
| public ModelInfo(Model model, ModelVersion[] modelVersion) { | |
| public ModelInfo(Model model, ModelVersion[] modelVersions) { |
Support model event to Gravitino server. Add list, get, create and delete events to both model and model version.
Fix some class comments.
Abyss-lord
force-pushed
the
model-event
branch
from
799df18 to
cd86b6a
Compare
|
Will review the PR these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support model event to Gravitino server. Add
list,get,createanddeleteevents to both model and model version.test case will add after EventDispatcher merged.
RegisterModelEventREGISTER_MODELregisterModelGetModelEventLOAD_MODELgetModelDropModelEventDROP_MODELdeleteModelListModelEventLIST_MODELlistModelsLinkModelVersionEventLINK_MODEL_VERSIONlinkModelVersionGetModelVersionEventGET_MODEL_VERSIONgetModelVersionDropModelVersionEventDROP_MODEL_VERSIONdeleteModelVersionListModelVersionsEventLIST_MODEL_VERSIONSlistModelVersionsWhy are the changes needed?
Fix: #6078
Does this PR introduce any user-facing change?
no
How was this patch tested?
local test.