[#6123] fix(CLI): Refactor the validation logic of tag and role #6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the validation logic of the Role and fix the test case.
Refactor the validation logic of the Tag and fix the test case.
|
Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. |
tengqm
reviewed
Jan 7, 2025
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Show resolved
Hide resolved
justinmclean
reviewed
Jan 7, 2025
| @@ -736,7 +724,7 @@ protected void handleTagCommand() { | |||
| } | |||
|
|
|||
| private String getOneTag(String[] tags) { | |||
| if (tags.length > 1) { | |||
| if (tags == null || tags.length > 1) { | |||
There was a problem hiding this comment.
I don't think it is possible for tags to be null at this point, but I guess it doesn't hurt
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 9, 2025
…apache#6127) ### What changes were proposed in this pull request? Refactor the validation logic of the Tag and Role, meantime fix the test case. ### Why are the changes needed? Fix: apache#6123 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ut + local test **Role test** ```bash gcli role grant -m demo_metalake --role admin # Missing --privilege option. gcli role revoke -m demo_metalake --role admin # Missing --privilege option. ``` **Tag test** ```bash gcli tag set -m demo_metalake # Missing --name option. gcli tag set -m demo_metalake --name catalog.schema.table --property property --tag tagA # Missing --value option. gcli tag set -m demo_metalake --name catalog.schema.table --value value --tag tagA # Missing --property option. gcli tag remove -m demo_metalake --tag tagA # Missing --name option. gcli tag remove -m demo_metalake # Missing --name option. gcli tag delete -m demo_metalake # Missing --tag option. gcli tag create -m demo_metalake # Missing --tag option. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor the validation logic of the Tag and Role, meantime fix the test case.
Why are the changes needed?
Fix: #6123
Does this PR introduce any user-facing change?
No
How was this patch tested?
ut + local test
Role test
Tag test