Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6121] fix(CLI): Refactor the validation logic of topic and fileset #6122

Merged

Conversation

Abyss-lord
Copy link
Contributor

What changes were proposed in this pull request?

Refactor the validation logic of fileset and topic, meanwhile fix the test case.

Why are the changes needed?

Fix: #6121

Does this PR introduce any user-facing change?

No

How was this patch tested?

ut + local test

Topic test

gcli topic set -m demo_metalake --name catalog.schema.topic 
# Missing --property and --value options.

gcli topic set -m demo_metalake --name catalog.schema.topic --property property
# Missing --value option.

gcli topic set -m demo_metalake --name catalog.schema.topic --value value
# Missing --property option.

gcli topic remove -m demo_metalake --name catalog.schema.topic 
# Missing --property option.

Fileset test

gcli fileset set -m demo_metalake --name catalog.schema.fileset
# Missing --property and --value options.

gcli fileset set -m demo_metalake --name catalog.schema.fileset --property property
# Missing --value option.

gcli fileset set -m demo_metalake --name catalog.schema.fileset --value value
# Missing --property option.

gcli fileset remove -m demo_metalake --name catalog.schema.fileset 
# Missing --property option.

…leset

Refactor the validation logic of topic and fix the test case.
…leset

Refactor the validation logic of fileset and fix the test case.
@Abyss-lord
Copy link
Contributor Author

Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback.

Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your work here

@justinmclean justinmclean merged commit 1884df6 into apache:main Jan 7, 2025
27 checks passed
@Abyss-lord Abyss-lord deleted the refactor-fileset-topic-validation branch January 7, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Refactor the validation logic of topic and fileset
2 participants