Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6112] fix(CLI): Refactor the validation logic of column and model #6120

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[#6112] fix(CLI): Refactor the validation logic of column and model #6120

merged 2 commits into from
Jan 7, 2025

Conversation

Abyss-lord
Copy link
Contributor

What changes were proposed in this pull request?

Refactor the validation logic of column and model.

Why are the changes needed?

Fix: #6112

Does this PR introduce any user-facing change?

No

How was this patch tested?

ut + local test

gcli model update -m demo_metalake --name catalog.schema.model
# Missing --uri option.

gcli column update -m demo_metalake --name Hive_catalog.default.test_dates.id --default
# Missing --datatype option.

@Abyss-lord
[apache#6112] fix(CLI): Refactor the validation logic of column and m…
2ce31d7 
…odel

Refactor the validation logic of model and fix the test case.
@Abyss-lord
[apache#6112] fix(CLI): Refactor the validation logic of column and m…
87a65e3 
…odel

Refactor the validation logic of model and fix the test case.
@Abyss-lord
Copy link
Contributor Author

Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback.

@tengqm
Copy link
Contributor

tengqm commented Jan 7, 2025

lgtm. thanks.

justinmclean
justinmclean approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks again

@justinmclean justinmclean merged commit d5a29a4 into apache:main Jan 7, 2025
27 checks passed
@Abyss-lord Abyss-lord deleted the refactor-column-model-validation branch January 7, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmclean justinmclean justinmclean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] Refactor the validation logic of column and model
3 participants
@Abyss-lord @tengqm @justinmclean