-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6024] feat(iceberg): refactor Iceberg credential code to reuse credential component in Gravitino server #6021
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,8 @@ | |
package org.apache.gravitino.credential.config; | ||
|
||
import com.google.common.collect.ImmutableMap; | ||
import java.util.Collections; | ||
import java.util.List; | ||
import java.util.Map; | ||
import org.apache.gravitino.Config; | ||
import org.apache.gravitino.config.ConfigBuilder; | ||
|
@@ -67,6 +69,14 @@ public class CredentialConfig extends Config { | |
false /* reserved */)) | ||
.build(); | ||
|
||
public static final ConfigEntry<List<String>> CREDENTIAL_PROVIDERS = | ||
new ConfigBuilder(CredentialConstants.CREDENTIAL_PROVIDERS) | ||
.doc("Credential providers, separated by comma.") | ||
.version(ConfigConstants.VERSION_0_8_0) | ||
.stringConf() | ||
.toSequence() | ||
.createWithDefault(Collections.emptyList()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's weird that changes to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The config entry defined here is not used to get providers, updated the code, please review again |
||
|
||
public static final ConfigEntry<Double> CREDENTIAL_CACHE_EXPIRE_RATIO = | ||
new ConfigBuilder(CredentialConstants.CREDENTIAL_CACHE_EXPIRE_RATIO) | ||
.doc( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a more meaningful exception instead of
RuntimeException
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated