[#5989] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao @yuqi1129 @orenccl please help to review when you have time, thanks |
|
What happen when they are not equals? |
no bad effect, but we'd better keep it consistent to make the system simple, The user create an credential provider with type A, we'd better produce the credential with type A too. |
|
LGTM. |
|
updating the PR to replace |
orenccl
approved these changes
Dec 26, 2024
|
Nice cleanup. |
|
@FANNG1 can you please rebase the PR to fix the conflicts? |
updated |
jerryshao
approved these changes
Dec 28, 2024
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…ot equal to the credential type of ADLSTokenCredential (apache#5990) ### What changes were proposed in this pull request? ADLSTokenCredentialProvider use the credential type from ADLSTokenCredential ### Why are the changes needed? Fix: apache#5989 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ADLSTokenCredentialProvider use the credential type from ADLSTokenCredential
Why are the changes needed?
Fix: #5989
Does this PR introduce any user-facing change?
no
How was this patch tested?
add test