[#5982] feat (gvfs-fuse): Implement Gravitino fileset file system #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � clients/filesystem-fuse/src/main.rs � Conflicts: � clients/filesystem-fuse/src/filesystem.rs � clients/filesystem-fuse/src/main.rs
diqiu50
changed the title
FANNG1
reviewed
Dec 27, 2024
FANNG1
reviewed
Dec 27, 2024
FANNG1
reviewed
Dec 30, 2024
|
|
||
| pub(crate) const CONF_GRAVITINO_METALAKE: ConfigEntity<&'static str> = ConfigEntity::new( | ||
| GravitinoConfig::MODULE_NAME, | ||
| "metalake", |
There was a problem hiding this comment.
No need to add a prefix. It is below GravitinoConfig::MODULE_NAME.
There was a problem hiding this comment.
it does not consist of gravitino_uri,
|
|
||
| pub(crate) const CONF_FUSE_FILE_MASK: ConfigEntity<u32> = ConfigEntity::new( | ||
| FuseConfig::MODULE_NAME, | ||
| "file_mask", |
There was a problem hiding this comment.
should we add filesystem prefix ?
There was a problem hiding this comment.
No need to add a prefix. It is below FuseConfig::MODULE_NAME.
|
|
||
| static SERVER: Lazy<Mutex<Option<Arc<FuseServer>>>> = Lazy::new(|| Mutex::new(None)); | ||
|
|
||
| pub(crate) enum CreateFsResult { |
There was a problem hiding this comment.
CreateFsResult is a little odd, please provide a better name
There was a problem hiding this comment.
CreateFileSystemResult is better?
FANNG1
approved these changes
Dec 31, 2024
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…em (apache#5984) ### What changes were proposed in this pull request? Implement an Gravitino fileset file system, Support mount fileset to local directory ### Why are the changes needed? Fix: apache#5982 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT and IT
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…em (apache#5984) ### What changes were proposed in this pull request? Implement an Gravitino fileset file system, Support mount fileset to local directory ### Why are the changes needed? Fix: apache#5982 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT and IT
jerryshao
pushed a commit
that referenced
this pull request
Jan 3, 2025
) ### What changes were proposed in this pull request? Implement an Gravitino fileset file system, Support mount fileset to local directory ### Why are the changes needed? Fix: #5982 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT and IT
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 4, 2025
…em (apache#5984) ### What changes were proposed in this pull request? Implement an Gravitino fileset file system, Support mount fileset to local directory ### Why are the changes needed? Fix: apache#5982 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT and IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement an Gravitino fileset file system, Support mount fileset to local directory
Why are the changes needed?
Fix: #5982
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT and IT