Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5954] feat(iceberg): Supports ADLS for Iceberg catalog and spark connector #5952

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Dec 23, 2024

What changes were proposed in this pull request?

  1. Most code work is implemented in [#5894] feat(iceberg): support Azure account key credential #5938 [#5624] feat(bundles): support ADLS credential provider #5737 including catalog properties convert and add Iceberg azure bundle jar, this PR mainly about test and document.
  2. Remove hidden properties of the cloud secret key from the Iceberg catalog, as Gravitino doesn't have an unified security management yet and Iceberg REST server need to fetch catalog cloud properties to initiate IcebergWrapper dymaticly. Another benefit is spark connector does not need to specify the secret key explictly.

Supports ADLS for Iceberg catalog and spark connector

Why are the changes needed?

Fix: #5954

Does this PR introduce any user-facing change?

Yes, the user no need to specify the cloud secret key in spark connector.

How was this patch tested?

test in local enviroment

@FANNG1 FANNG1 marked this pull request as draft December 23, 2024 09:06
@FANNG1 FANNG1 changed the title Supports ADLS for Iceberg catalog and spark connector [#5954] feat(iceberg): Supports ADLS for Iceberg catalog and spark connector Dec 23, 2024
@FANNG1 FANNG1 marked this pull request as ready for review December 23, 2024 10:01
@FANNG1
Copy link
Contributor Author

FANNG1 commented Dec 23, 2024

@yuqi1129 @jerryshao please help to review, thanks

@jerryshao jerryshao assigned jerryshao and FANNG1 and unassigned jerryshao Dec 24, 2024
@jerryshao jerryshao merged commit 5f0dcb7 into apache:main Dec 24, 2024
26 checks passed
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this pull request Dec 29, 2024
…ark connector (apache#5952)

### What changes were proposed in this pull request?

1. Most code work is implemented in apache#5938 apache#5737 including catalog
properties convert and add Iceberg azure bundle jar, this PR mainly
about test and document.
2. Remove hidden properties of the cloud secret key from the Iceberg
catalog, as Gravitino doesn't have an unified security management yet
and Iceberg REST server need to fetch catalog cloud properties to
initiate `IcebergWrapper` dymaticly. Another benefit is spark connector
does not need to specify the secret key explictly.

Supports ADLS for Iceberg catalog and spark connector

### Why are the changes needed?
Fix: apache#5954 

### Does this PR introduce _any_ user-facing change?
Yes, the user no need to specify the cloud secret key in spark
connector.

### How was this patch tested?
test in local enviroment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Support ADLS storage for Gravitino Iceberg catalog and Spark connector
2 participants