[#5924] improvement(CLI): fix cli list command produce no outputs #5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the list command, it’s helpful to provide a friendly reminder if no data is retrieve.
|
Hi @justinmclean @xunliu @tengqm , could you please review this PR when you have a moment? I’d really appreciate your feedback. |
|
lgtm |
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakes.java
Show resolved
Hide resolved
justinmclean
previously approved these changes
Dec 22, 2024
tengqm
reviewed
Dec 23, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java
Show resolved
Hide resolved
…stAllTags.java Co-authored-by: Qiming Teng <[email protected]>
|
Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. |
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakes.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopics.java
Outdated
Show resolved
Hide resolved
fix output message "No XXXs" is still a plural.
|
@justinmclean @xunliu , I’ve finished updating the code. Please take a look at the PR again when you have time. |
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…ts (apache#5942) ### What changes were proposed in this pull request? When using the list command, it’s helpful to provide a friendly information if no data is retrieve. ### Why are the changes needed? Fix: apache#5924 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? ```bash bin/gcli.sh catalog list -m demo_metalake2 # No catalogs exists. bin/gcli.sh table list -m demo_metalake --name Hive_catalog.empty # output: No tables exists. ``` --------- Co-authored-by: Qiming Teng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When using the list command, it’s helpful to provide a friendly information if no data is retrieve.
Why are the changes needed?
Fix: #5924
Does this PR introduce any user-facing change?
NO
How was this patch tested?