[#5778] feat(aliyun-bundles)support OSS secret key credential #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunxiaojian
force-pushed
the
OSS-secret-key-credential
branch
3 times, most recently
from
23ddbbe to
9b54973
Compare
|
@FANNG1 PTAL |
|
LGTM except for minor comments, could you do extra work?
|
FANNG1
reviewed
Dec 11, 2024
| * @param secretAccessKey The OSS static secret access key. | ||
| */ | ||
| public OSSSecretKeyCredential(String accessKeyId, String secretAccessKey) { | ||
| Preconditions.checkNotNull(accessKeyId, "OSS access key Id should not null"); |
There was a problem hiding this comment.
could you reuse validate here?
ok， fixed |
sunxiaojian
force-pushed
the
OSS-secret-key-credential
branch
from
c41d9a5 to
acf90bf
Compare
sunxiaojian
force-pushed
the
OSS-secret-key-credential
branch
from
acf90bf to
01330b4
Compare
FANNG1
approved these changes
Dec 11, 2024
|
LGTM |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 12, 2024
…pache#5814) ### What changes were proposed in this pull request? Support OSS secret key credential ### Why are the changes needed? Fix: [# (5778)](apache#5778) ### How was this patch tested? IcebergRESTOSSSecretIT
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 13, 2024
…pache#5814) ### What changes were proposed in this pull request? Support OSS secret key credential ### Why are the changes needed? Fix: [# (5778)](apache#5778) ### How was this patch tested? IcebergRESTOSSSecretIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support OSS secret key credential
Why are the changes needed?
Fix: # (5778)
How was this patch tested?
IcebergRESTOSSSecretIT