[#5697] feat(core): Fix unexpected warning in AuxiliaryServiceManager #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Dec 9, 2024
| config | ||
| .getAllConfig() | ||
| config.getAllConfig().entrySet().stream() | ||
| .filter(entry -> !entry.getKey().equals("gravitino.auxService.names")) |
There was a problem hiding this comment.
could you replace gravitino.auxService.names with GRAVITINO_AUX_SERVICE_PREFIX + AUX_SERVICE_NAMES?
frankvicky
force-pushed
the
fix-warning
branch
from
5cf9181 to
47c207d
Compare
frankvicky
force-pushed
the
fix-warning
branch
from
47c207d to
255919c
Compare
FANNG1
approved these changes
Dec 9, 2024
FANNG1
changed the title
|
@frankvicky , merged to main, welcome to join the Gravitino community, and hope you enjoy the journey. |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 13, 2024
…anager (apache#5800) ### What changes were proposed in this pull request? Adding a filter operator to filter out gravitino.auxService.names. ### Why are the changes needed? Currently it will lead to unexpected warning which is confusing. Fix: apache#5697 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the issue #5697
Adding a filter operator to filter out unexpected key.
Why are the changes needed?
Currently it will lead to unexpected warning which is confusing.
Fix: #5697
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test locally