[#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 1, 2024 14:18
…avitino into support-paimon-connector-ddl
caican00
force-pushed
the
support-paimon-connector-ddl
branch
from
5987b11 to
659338f
Compare
…avitino into support-paimon-connector-ddl
…avitino into support-paimon-connector-ddl
caican00
changed the title
|
Hi @FANNG1 could you help review this pr? Thanks!!! |
FANNG1
reviewed
Dec 11, 2024
...ommon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonPropertiesUtils.java
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonPropertiesUtils.java
Show resolved
Hide resolved
...spark-common/src/main/java/org/apache/gravitino/spark/connector/paimon/SparkPaimonTable.java
Outdated
Show resolved
Hide resolved
...ommon/src/test/java/org/apache/gravitino/spark/connector/integration/test/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/gravitino/spark/connector/integration/test/paimon/SparkPaimonCatalogIT.java
Show resolved
Hide resolved
|
LGTM, just minor comments. Besides, do you plan to add HIVE and JDBC catalog backend IT? |
i will implememt these in another prs. |
caican00
force-pushed
the
support-paimon-connector-ddl
branch
from
5c446dc to
f8220e5
Compare
|
comments have been addressed. cc @FANNG1 |
FANNG1
approved these changes
Dec 16, 2024
|
merged to main, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector.
Why are the changes needed?
Fix:
#4722
#4717
Does this PR introduce any user-facing change?
No.
How was this patch tested?
new Its and UTs.