[FLINK-36794] [cdc-composer/cli] pipeline cdc connector support multiple data sources #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
| stream = stream.union(streamBranch); | ||
| } | ||
| } | ||
| boolean isParallelMetadataSource = dataSource.isParallelMetadataSource(); |
There was a problem hiding this comment.
I think multi data sources should be regarded as parallelized.
|
|
||
| ```yaml | ||
| source: | ||
| type: mysql_mutiple |
There was a problem hiding this comment.
Should we use a new key like 'sources' to describe multiple sources? The '_multiple' suffix in value seems a bit odd. Because the YAML content does not correspond one-to-one with the PipelineDef.
| private static final String HOST_NAME = "hostname"; | ||
| private static final String PORT = "port"; | ||
| private static final String COLON = ":"; | ||
| private static final String MUTIPLE = "_mutiple"; |
There was a problem hiding this comment.
Should be _multiple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline cdc connector support multiple data sources