Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36952][source-connector/mongodb] Fix MongoDB connector Chinese documentation #3811

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

Thorne-coder
Copy link
Contributor

@github-actions github-actions bot added the docs Improvements or additions to documentation label Dec 23, 2024
@Thorne-coder
Copy link
Contributor Author

@Jiabao-Sun @yuxiqian PTAL

Copy link
Contributor

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @Thorne-coder's fix!

@@ -147,7 +147,7 @@ SELECT * FROM products;
**请注意**

MongoDB 的更改事件记录在消息之前没有更新。因此,我们只能将其转换为 Flink 的 UPSERT 更改日志流。
upstart 流需要一个唯一的密钥,所以我们必须声明 `_id` 作为主键。
因为 upsert 流需要一个唯一的密钥,所以我们必须声明 `_id` 作为主键。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
因为 upsert 流需要一个唯一的密钥,所以我们必须声明 `_id` 作为主键。
因为 upsert 流需要唯一键,所以我们必须声明 `_id` 作为主键。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u for u review and i fix it .

@@ -367,7 +367,7 @@ MongoDB CDC 连接器是一个 Flink Source 连接器,它将首先读取数据

### 启动模式<a name="启动模式" id="002" ></a>

配置选项```scan.startup.mode```指定 MySQL CDC 使用者的启动模式。有效枚举包括:
配置选项```scan.startup.mode```指定 MongoDB CDC 使用者的启动模式。有效枚举包括:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
配置选项```scan.startup.mode```指定 MongoDB CDC 使用者的启动模式。有效枚举包括:
配置选项```scan.startup.mode```指定 MongoDB CDC 消费者的启动模式。有效枚举包括:

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thorne-coder for this fix.
LGMT.

@Jiabao-Sun Jiabao-Sun changed the title [FLINK-36952][hotfix][mongodb]Fix MongoDB connector Chinese documentation [FLINK-36952][hotfix][source-connector/mongodb] Fix MongoDB connector Chinese documentation Dec 24, 2024
@Jiabao-Sun Jiabao-Sun changed the title [FLINK-36952][hotfix][source-connector/mongodb] Fix MongoDB connector Chinese documentation [FLINK-36952][source-connector/mongodb] Fix MongoDB connector Chinese documentation Dec 24, 2024
@Jiabao-Sun Jiabao-Sun merged commit 4f881f8 into apache:master Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved docs Improvements or additions to documentation reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants