[FLINK-36879][runtime] Support to convert delete as insert in transform #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiqian
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Thanks for @ruanhang1993's nice work, just left some trivial comments.
| @@ -316,6 +317,10 @@ private TransformDef toTransformDef(JsonNode transformNode) { | |||
| Optional.ofNullable(transformNode.get(TRANSFORM_DESCRIPTION_KEY)) | |||
| .map(JsonNode::asText) | |||
| .orElse(null); | |||
| String convertDeleteAsInsert = | |||
| Optional.ofNullable(transformNode.get(TRANSFORM_CONVERT_DELETE_AS_INSERT_KEY)) | |||
| .map(JsonNode::asText) | |||
There was a problem hiding this comment.
We can simply call JsonNode::asBoolean here
| @@ -74,4 +77,8 @@ public String getPartitionKey() { | |||
| public String getTableOption() { | |||
| return tableOption; | |||
| } | |||
|
|
|||
| public boolean isconvertDeleteAsInsert() { | |||
There was a problem hiding this comment.
Suggested change
| public boolean isconvertDeleteAsInsert() { | |
| public boolean isConvertDeleteAsInsert() { |
| @@ -448,6 +455,17 @@ private Optional<DataChangeEvent> processDataChangeEvent(DataChangeEvent dataCha | |||
| } | |||
| } | |||
|
|
|||
| private Optional<DataChangeEvent> concertDeleteAsInsert(DataChangeEvent dataChangeEvent) { | |||
There was a problem hiding this comment.
Suggested change
| private Optional<DataChangeEvent> concertDeleteAsInsert(DataChangeEvent dataChangeEvent) { | |
| private Optional<DataChangeEvent> convertDeleteAsInsert(DataChangeEvent dataChangeEvent) { |
Typo
| @@ -50,4 +53,8 @@ public Optional<TransformProjection> getProjection() { | |||
| public Optional<TransformFilter> getFilter() { | |||
| return filter; | |||
| } | |||
|
|
|||
| public boolean isconvertDeleteAsInsert() { | |||
There was a problem hiding this comment.
Suggested change
| public boolean isconvertDeleteAsInsert() { | |
| public boolean isConvertDeleteAsInsert() { |
Use camelCase
| @@ -47,6 +47,7 @@ transform: | |||
| partition-keys: product_name | |||
| table-options: comment=app order | |||
| description: project fields from source table | |||
| convert-delete-as-insert: true | |||
There was a problem hiding this comment.
Docs in Core Concepts / Transform needs to be updated, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to convert delete as insert in transform