[FLINK-36854] Fix comments and default expressions missing after being transformed #3780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-36854.
Consider the following simple schema:
[id INT NOT NULL COMMENT 'id_field' DEFAULT 17]
This would be sync to downstream sink databases that supports them intactly.
However, things would go wrong after being transformed like this:
Here,
id_new
column should carry no comments / default expressions obviously, since it has nothing to do with originalid
technically.However, for
id
andid_alias
column, it's reasonable to expect that comments and default expressions to be kept. Worse still, the nullability ofid_alias
will be lost since the previous half is regarded as a complex expression, and nullability of an expression's return type is uncertain.So, currently the transform will yields the following schema:
With this PR, deduced schema will be something like: