[FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add this option |
…ing prepare common of PaimonWriter to avoid CME problem
stayrascal
force-pushed
the
36790-paimon-dv
branch
from
f3ed283 to
ac65f4d
Compare
Thanks for reviewing, do you know how to rerun the CI since one pipeline failed? |
|
The failure of CI is case of postgres connector, which is unrelated to the changes, I think that it didn't block this pr, we can trace it in another issue. |
ok, so what can I do and then the PR can be merged? |
|
@ruanhang1993 @leonardBang Could you please take a look at this? |
leonardBang
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set waitCompaction with true during prepare common of PaimonWriter to avoid CME problem