Rename BuiltInWindow* to StandardWindow*
#13536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
reviewed
Nov 23, 2024
| pub use sliding_aggregate::SlidingAggregateWindowExpr; | ||
| pub use udf::UDFWindowExpr; |
There was a problem hiding this comment.
Could you please add a "backwards compatible typedef" here to help people upgrading who might have code that refers to BuiltInWindowExpr and BuiltInWindowFunctionExpr?
For example
datafusion/datafusion/physical-expr-common/src/sort_expr.rs
Lines 505 to 506 in 6a02384
Something like
#[deprecated(since = "44.0.0", note = "use UDFWindowExpr")]
pub type BuiltInWindowExpr = UDFWindowExpr;
#[deprecated(since = "44.0.0", note = "use UDFWindowFunctionExpr")]
pub type BuiltInWindowFunctionExpr = UDFWindowFunctionExpr;| mod sliding_aggregate; | ||
| mod udf; |
There was a problem hiding this comment.
It is somewhat strange that we now have "UD ..." for user defined window functions as everything is a user defined window function.
Maybe we could use the names StandardWindowExpr and StandardWindowFunctionExpr instead
I think WindowExpr can be either an aggregate (like sum) or one of these standard window exprs (first_value, etc)
alamb
changed the title
BuiltInWindow* to UDFWindow*BuiltInWindow* to StandardWindow*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #13473
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?