Move filtered SMJ Left Anti filtered join out of join_partial phase
#13111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
comphead
commented
Oct 25, 2024
| #) order by 1, 2 | ||
| #---- | ||
| query III | ||
| select * from ( |
comphead
commented
Oct 25, 2024
| @@ -223,17 +224,14 @@ async fn test_anti_join_1k() { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| // flaky for HjSmj case, giving 1 rows difference sometimes | |||
| // https://github.com/apache/datafusion/issues/11555 | |||
| #[ignore] | |||
| async fn test_anti_join_1k_filtered() { | |||
1 task
alamb
approved these changes
Oct 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #12359
Follow up on #12764
Rationale for this change
Same as #12764 but for Left Anti join
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?