fix: Produce buffered null join row only if all joined rows are failed on join filter in SMJ full join #12090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Aug 20, 2024
| @@ -134,7 +134,6 @@ Alice 100 NULL NULL | |||
| Alice 50 Alice 2 | |||
| Bob 1 NULL NULL | |||
| NULL NULL Alice 1 | |||
| NULL NULL Alice 2 | |||
There was a problem hiding this comment.
This is incorrect. Alice 2 was joined with Alice 50 above. We should not produce null join row for it.
There was a problem hiding this comment.
double checked the joins, it looks correct
|
Found this bug during debugging apache/datafusion-comet#553. |
viirya
commented
Aug 20, 2024
| query IIII | ||
| select * from ( | ||
| with t as ( | ||
| select id_a id_a_1, id_a % 5 id_a_2 from (select unnest(make_array(5, 6, 7, 8, 9, 0, 1, 2, 3, 4)) id_a) |
There was a problem hiding this comment.
The order of the values in the array is important. If it is 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, it cannot test against the bug.
github-actions
bot
added
physical-expr
comphead
reviewed
Aug 20, 2024
comphead
reviewed
Aug 20, 2024
comphead
approved these changes
Aug 21, 2024
|
Thanks @comphead |
|
FYI @richox |
|
I also checked the SMJ benchmarks are running good on this branch |
|
Thank you @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12091.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?