feat: Date and timestamp trunc with format array #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: date and timestamp trunc with format array
viirya
approved these changes
Feb 22, 2024
|
@viirya thank you for the approval (and review). Will wait for other comments and ci before merging. |
sunchao
changed the title
sunchao
changed the title
|
Merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: date and timestamp trunc with format array
Which issue does this PR close?
Closes #93
Rationale for this change
Compatibility with Spark
What changes are included in this PR?
Implements support for the
formatparameter to be an array.How are these changes tested?
Adds additional unit tests