fix: Optimize CheckOverflow #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before
After
|
andygrove
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=============================================
+ Coverage 34.05% 55.15% +21.09%
+ Complexity 879 857 -22
=============================================
Files 112 109 -3
Lines 42959 10542 -32417
Branches 9488 2010 -7478
=============================================
- Hits 14629 5814 -8815
+ Misses 25330 3714 -21616
+ Partials 3000 1014 -1986 ☔ View full report in Codecov by Sentry. |
|
Merged, thanks @andygrove |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
## Which issue does this PR close? ## Rationale for this change This PR improves CheckOverflow performance ## What changes are included in this PR? This PR directly calls arrow validation methods ## How are these changes tested? Existing tests (cherry picked from commit 829656c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR improves CheckOverflow performance
What changes are included in this PR?
This PR directly calls arrow validation methods
How are these changes tested?
Existing tests