-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable Comet shuffle with AQE coalesce partitions #834
Conversation
This is a copy of #651 but removed some changes. I'd like to see if "os cannot spawn new native thread" error could be removed. And I also want to check if core-1 can pass without these changes on ubuntu-24.04. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
============================================
+ Coverage 33.83% 33.92% +0.09%
Complexity 870 870
============================================
Files 112 112
Lines 42970 42909 -61
Branches 9466 9473 +7
============================================
+ Hits 14538 14557 +19
+ Misses 25446 25352 -94
- Partials 2986 3000 +14 ☔ View full report in Codecov by Sentry. |
After changing to ubuntu 24.04, the negative ref count error like following disappears on Spark 3.4.3, although it still happens on Spark 4.0.0 and Spark 3.5.1. Note that it only happens on
|
As it cannot be reproduced locally and on internal CI, I'm going to disable columnar shuffle in |
For Spark 3.4.3, it is also probably negative ref count error happening on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @viirya!
Thanks @andygrove |
* chore: Remove COMET_SHUFFLE_ENFORCE_MODE_ENABLED * Update plan stability * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Remove test * Update * Use same allocator * test * Add synchronized * test * Revert "test" This reverts commit 5574bf5. * Revert "Add synchronized" This reverts commit aac200a. * Fix * fix * Update diffs * Update diffs * Add CometColumnarBatch * Change to ubuntu-20.04. * Change to macos-latest * Change to ubuntu-24.04 * update 3.4.3..diff * Update to ubuntu-24.04 for Spark 4.0.0 pipeline * Revert some changes * Disable Comet shuffle for Spark SQL core-1 test on Spark 3.5 and 4.0.0 * Disable Comet shuffle for Spark SQL core-1 on Spark 3.4.3 too.
Which issue does this PR close?
Closes #387.
Rationale for this change
What changes are included in this PR?
How are these changes tested?