feat: Implement basic version of RLIKE #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Jul 28, 2024
Comment on lines
+25
to
+30
| def isSupportedPattern(pattern: String): Boolean = { | ||
| // this is a placeholder for implementing logic to determine if the pattern | ||
| // is known to be compatible with Spark, so that we can enable regexp automatically | ||
| // for common cases and fallback to Spark for more complex cases | ||
| false | ||
| } |
There was a problem hiding this comment.
I plan on implementing this in a future PR
|
Last time, we had a discussion around dictionary #469 (comment) |
Yes, the test now covers the dictionary case (as far as I can tell). The expression is never invoked with a dictionary though , so it seems to be converted before reaching the expression. |
Comment on lines
625
to
626
| val data = Seq("James Smith", "Michael Rose", "Rames Rose", "Rames rose") ++ | ||
| gen.generateStrings(100, "rames Rose", 12) |
There was a problem hiding this comment.
I think we need enough number of repeated strings in order to make a dictionary. Right now, it has a low chance due to the randomness...
There was a problem hiding this comment.
@kazuyukitanimura I updated the test and have now added dictionary support
|
microbenchmark results: |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit e33d560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
RLIKE is pretty common in ETL jobs.
What changes are included in this PR?
This PR implements the RLIKE expression, but falls back to Spark for all regexp patterns that are not currently guaranteed to be compatible (which is all of them for now) unless a new config (
spark.comet.regexp.allowIncompatible) is enabled.How are these changes tested?
New tests