chore: make Cast's logic reusable for other projects #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spark-compatible "Cast" is implemented as a physical expr in Comet, but other downstream projects might like to use it as a logical expr. To facilitate it, this makes the core logic invokable through pub fn spark_cast_array.
Blizzara
commented
Jul 24, 2024
native/spark-expr/src/lib.rs
Outdated
| @@ -24,7 +24,7 @@ mod temporal; | |||
| pub mod timezone; | |||
| pub mod utils; | |||
|
|
|||
| pub use cast::Cast; | |||
| pub use cast::{Cast, spark_cast_array}; | |||
There was a problem hiding this comment.
the export is not needed by comet, but it allows others (eg. us) to use spark_cast_array directly
andygrove
reviewed
Jul 24, 2024
native/spark-expr/src/cast.rs
Outdated
| } | ||
| }; | ||
| Ok(spark_cast(cast_result?, from_type, to_type)) | ||
| pub fn spark_cast_array( |
There was a problem hiding this comment.
If we are making this public, we should add some documentation. I think there is a clippy lint that we should turn on to make sure all pub items have rustdocs.
There was a problem hiding this comment.
added some in eaf224d! Though not sure what exactly would be useful here, lmk if you had anything specifc in mind :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=============================================
- Coverage 53.66% 33.63% -20.04%
- Complexity 810 827 +17
=============================================
Files 107 110 +3
Lines 10265 42557 +32292
Branches 1930 9358 +7428
=============================================
+ Hits 5509 14312 +8803
- Misses 3781 25291 +21510
- Partials 975 2954 +1979 ☔ View full report in Codecov by Sentry. |
andygrove
approved these changes
Jul 25, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit 8482150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Spark-compatible "Cast" is implemented as a physical expr in Comet, but other downstream projects might like to use it as a logical expr. To facilitate it, this makes the core logic invokable through
pub fn spark_cast.What changes are included in this PR?
Makes some
Caststruct's functions static, and moves those plus a bunch existing of static functions out of Cast impl.Moves ColumnarValue handling logic out of Cast::evaluate into
spark_cast, and makes that public.Exports
spark_castfrom spark-expr/libRecommend reviewing with "Hide whitespace" ON.
How are these changes tested?
Existing tests