perf: Optimize IfExpr by delegating to CaseExpr #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
force-pushed
the
bench-conditional
branch
from
30fe587 to
9b886d9
Compare
andygrove
changed the title
|
Note that there is a small regression in the edit: Issue filed as apache/datafusion#11638 |
huaxingao
approved these changes
Jul 24, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* Unify IF and CASE expressions * revert test changes * fix (cherry picked from commit ded3dd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #680
Rationale for this change
Rather than maintain a custom
IfExpr, we can just delegate toCaseExprand benefit from recent optimization work there.What changes are included in this PR?
IfExprnow is just a wrapper forCaseExprHow are these changes tested?