chore: Fix some regressions with Spark 3.5.1 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthchandra @kazuyukitanimura This PR is ready for review now and fixes almost all of the ignored tests for Spark 3.5.1. I will follow up with a separate PR for the final two tests. |
| ShimFileFormat.findRowIndexColumnIndexInSchema(sparkSchema) >= 0 | ||
| } | ||
| // see SPARK-39634 | ||
| protected def isNeededForSchema(sparkSchema: StructType): Boolean = false |
There was a problem hiding this comment.
We still have this in the 4.0 shim. Is this not needed any more?
There was a problem hiding this comment.
nvm. I was looking at the wrong file. This is also changed in the 4.0 shim.
There was a problem hiding this comment.
I updated this to match the version in the 4.0 shims because https://issues.apache.org/jira/browse/SPARK-39634 is marked as fixed in 3.5
|
@kazuyukitanimura @huaxingao Could I get a committer review? Parth has already approved. |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #617
Rationale for this change
What changes are included in this PR?
How are these changes tested?