Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move protobuf files to separate crate #661

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jul 14, 2024

Which issue does this PR close?

N/A

Rationale for this change

Splitting the project into smaller crates has some benefits:

  • Helps with build times
  • Allows other Rust projects to re-use parts of Comet
  • Improves maintainability and allows for debugging/testing modules in isolation

What changes are included in this PR?

  • Move protobuf files and build.rs into separate crate
  • No functional changes

How are these changes tested?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.65%. Comparing base (b6d868c) to head (04735f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #661   +/-   ##
=========================================
  Coverage     33.65%   33.65%           
  Complexity      842      842           
=========================================
  Files           109      109           
  Lines         42573    42573           
  Branches       9334     9334           
=========================================
  Hits          14328    14328           
  Misses        25297    25297           
  Partials       2948     2948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

native/proto/README.md Outdated Show resolved Hide resolved
Co-authored-by: Liang-Chi Hsieh <[email protected]>
@andygrove andygrove merged commit de8c55e into apache:main Jul 15, 2024
74 checks passed
@andygrove andygrove deleted the protobuf-crate branch July 15, 2024 20:55
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* move protobuf files to separate crate

* format

* revert accidental delete

* Update native/proto/README.md

Co-authored-by: Liang-Chi Hsieh <[email protected]>

---------

Co-authored-by: Liang-Chi Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants