Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade DF to 36.0.0 and arrow-rs 50.0.0 #66

Merged
merged 6 commits into from
Feb 28, 2024
Merged

build: Upgrade DF to 36.0.0 and arrow-rs 50.0.0 #66

merged 6 commits into from
Feb 28, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #56.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@comphead comphead requested review from sunchao and viirya February 20, 2024 23:53
@comphead comphead mentioned this pull request Feb 20, 2024
Merged
viirya
viirya requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this until internal patches are ported to Comet. Thanks.

@sunchao sunchao changed the title Upgrade DF to 36.0.0 and arrow-rs 50.0.0 build: Upgrade DF to 36.0.0 and arrow-rs 50.0.0 Feb 21, 2024
@sunchao
Copy link
Member

sunchao commented Feb 21, 2024

I think we should wait for 36.0.1?

@viirya
Copy link
Member

viirya commented Feb 21, 2024

Yea

@comphead
Copy link
Contributor Author

I think we should wait for 36.0.1?

Just curious, what is so interesting in 36.0.1? 🤔

@viirya
Copy link
Member

viirya commented Feb 22, 2024

I think @andygrove encountered circular dependency issue while releasing 36.0.0. So there is 36.0.1 after fixing the issue.

@sunchao
Copy link
Member

sunchao commented Feb 25, 2024

Looks like 36.0.1 is abandoned. Shall we move forward with this PR?

@viirya
Copy link
Member

viirya commented Feb 26, 2024

Sounds good to me.

@comphead comphead requested a review from viirya February 27, 2024 22:47
@comphead comphead merged commit ee977c3 into apache:main Feb 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunchao sunchao sunchao approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade DF to 36.0.0, arrow-rs to 50.0.0
3 participants
@comphead @sunchao @viirya