-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move cast
to spark-expr
crate
#654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=========================================
Coverage 53.82% 53.82%
Complexity 811 811
=========================================
Files 106 106
Lines 10242 10242
Branches 1917 1917
=========================================
Hits 5513 5513
Misses 3752 3752
Partials 977 977 ☔ View full report in Codecov by Sentry. |
// | Any other type | Not Supported | | ||
// | --------------------- | ------------ | ----------------- | -------------------------------- | | ||
// | ||
pub fn array_with_timezone( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these functions are specified to Spark cast. Maybe they should be with cast expression in spark-expr crate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array_with_timezone
is also called from some other expressions in temporal.rs
. Once all the expressions are moved to the new crate then maybe we can move some of these utility functions there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose some of these functions could just live in the spark-expr crate. I will look at that as a follow on issue.
* refactor in preparation for moving cast to spark-expr crate * errors * move cast to spark-expr crate * machete * refactor errors * clean up imports
Which issue does this PR close?
Part of #630
Rationale for this change
Move another expr to the new spark-expr crate.
What changes are included in this PR?
Just moving code around. No functional changes.
Specific changes
spark_cast
function fromutils.rs
tocast.rs
to keep all cast code togetherdatafusion_comet_utils
cast.rs
intodatafusion_comet_spark_expr
How are these changes tested?
Existing tests