Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create new datafusion-comet-spark-expr crate containing Spark-compatible DataFusion expressions #638

Merged
merged 19 commits into from
Jul 10, 2024
Merged

feat: Create new datafusion-comet-spark-expr crate containing Spark-compatible DataFusion expressions #638

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
520559d
convert into workspace project
andygrove Jul 6, 2024
1d39229
update GitHub actions
andygrove Jul 6, 2024
cb64234
update Makefile
andygrove Jul 6, 2024
4617f8a
fix regression
andygrove Jul 6, 2024
d033246
update target path
andygrove Jul 6, 2024
91f1c0b
update protobuf path in pom.xml
andygrove Jul 6, 2024
e7fff73
update more paths
andygrove Jul 6, 2024
c900020
add new datafusion-comet-expr crate
andygrove Jul 6, 2024
57ce6fd
rename CometAbsFunc to Abs and add documentation
andygrove Jul 7, 2024
3caf372
fix error message
andygrove Jul 7, 2024
b98cb34
improve error handling
andygrove Jul 7, 2024
c2fb936
update crate description
andygrove Jul 7, 2024
00751b0
upmerge
andygrove Jul 8, 2024
33ce09a
remove unused dep
andygrove Jul 8, 2024
487ac57
address feedback
andygrove Jul 9, 2024
7c093aa
finish renaming crate
andygrove Jul 9, 2024
dc665ab
update README for datafusion-spark-expr
andygrove Jul 9, 2024
8eec13e
rename crate to datafusion-comet-spark-expr
andygrove Jul 9, 2024
4be923f
upmerge
andygrove Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions native/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 22 additions & 1 deletion native/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
# under the License.

[workspace]
members = ["core"]
members = ["core", "spark-expr"]
resolver = "2"

[workspace.package]
version = "0.1.0"
Expand All @@ -30,3 +31,23 @@ edition = "2021"

# Comet uses the same minimum Rust version as DataFusion
rust-version = "1.75"

[workspace.dependencies]
arrow = { git = "https://github.com/apache/arrow-rs.git", rev = "0a4d8a1", features = ["prettyprint", "ffi", "chrono-tz"] }
arrow-array = { git = "https://github.com/apache/arrow-rs.git", rev = "0a4d8a1" }
arrow-buffer = { git = "https://github.com/apache/arrow-rs.git", rev = "0a4d8a1" }
arrow-data = { git = "https://github.com/apache/arrow-rs.git", rev = "0a4d8a1" }
arrow-schema = { git = "https://github.com/apache/arrow-rs.git", rev = "0a4d8a1" }
datafusion-common = { git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1" }
datafusion = { default-features = false, git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1", features = ["unicode_expressions", "crypto_expressions"] }
datafusion-functions = { git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1", features = ["crypto_expressions"] }
datafusion-expr = { git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1", default-features = false }
datafusion-physical-expr-common = { git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1", default-features = false }
datafusion-physical-expr = { git = "https://github.com/viirya/arrow-datafusion.git", rev = "17446b1", default-features = false }

[profile.release]
debug = true
overflow-checks = false
lto = "thin"
codegen-units = 1
strip = "debuginfo"
Loading
Loading