Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update benchmark results #614

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jun 30, 2024

Which issue does this PR close?

Related to #595

Rationale for this change

What changes are included in this PR?

  • Run Comet benchmark with 32GB memory instead of 64GB memory, to match Spark benchmark
  • Enable coalesce partitions to reduce query regressions

How are these changes tested?

@andygrove andygrove marked this pull request as ready for review June 30, 2024 18:11
Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viirya viirya merged commit 106b212 into apache:main Jul 1, 2024
67 checks passed
@viirya
Copy link
Member

viirya commented Jul 1, 2024

Merged. Thanks @andygrove @parthchandra

himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* Update benchmark script and results

* update diagrams

* update docs

* revert cbo change
@andygrove andygrove deleted the update-benchmark-results branch December 3, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants