Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use proper constructor of IndexShuffleBlockResolver #610

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 29, 2024

Which issue does this PR close?

Closes #609.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya force-pushed the index_shuffle_resolver branch from d3dc8cd to f55a3b2 Compare June 29, 2024 06:21
@viirya
Copy link
Member Author

viirya commented Jun 29, 2024

cc @kazuyukitanimura

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.23%. Comparing base (2aa20f0) to head (f55a3b2).
Report is 3 commits behind head on main.

Files Patch % Lines
.../comet/execution/shuffle/CometShuffleManager.scala 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #610       +/-   ##
=============================================
- Coverage     54.66%   34.23%   -20.43%     
- Complexity      792      798        +6     
=============================================
  Files           103      106        +3     
  Lines          9713    38546    +28833     
  Branches       1851     8552     +6701     
=============================================
+ Hits           5310    13198     +7888     
- Misses         3451    22605    +19154     
- Partials        952     2743     +1791     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Jul 1, 2024

cc @andygrove

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@kazuyukitanimura kazuyukitanimura merged commit 42ed636 into apache:main Jul 1, 2024
66 checks passed
@viirya
Copy link
Member Author

viirya commented Jul 1, 2024

Thanks @kazuyukitanimura

@viirya viirya deleted the index_shuffle_resolver branch July 1, 2024 19:09
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CometShuffleManager to adapt IndexShuffleBlockResolver signature change
3 participants