perf: Add criterion benchmark for xxhash64 function #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Jun 13, 2024
advancedxy
reviewed
Jun 13, 2024
| @@ -95,6 +96,16 @@ fn criterion_benchmark(c: &mut Criterion) { | |||
| }); | |||
| }, | |||
| ); | |||
| group.bench_function(BenchmarkId::new("xxhash64", BATCH_SIZE), |b| { | |||
There was a problem hiding this comment.
Thanks @andygrove. Could we extend this PR a bit and add a murmur3 hash benchmark as well?
In that way, I think we can get a sense of how slow xxhash64 is.
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* add benchmark for xxhash64 * remove new code * add murmur3 bench * format * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #547
Rationale for this change
We suspect that we may have a performance issue in xxhash64, so the first step is to add a benchmark to evaluate current performance.
What changes are included in this PR?
New criterion benchmark
How are these changes tested?
Here are the results from Apple M3 Max.